Tag a new stable version that is compatible with Symfony 3.0

[teohhanhui]

See minkphp/MinkBrowserKitDriver#103

As @aik099 pointed out, there's no stable version of behat/mink that works with Symfony 3.0 yet.

[stof]

This is on my plan, but I need to check the existing issue in the driver testsuite before doing a release (to check whether the bug is only in drivers, or also in the newly added test)

[sroze]

Which issue @stof? I could have a look too.

[stof]

the new test about cookies with a semi-colon. This triggers a weird error in zombie driver, which is related to an invalid usage of the API in the test itself: setting a cookie without visiting a page first is an unsupported usage of Mink (some drivers may accept it, but it does not work cross-driver, and could even set the cookie on the wrong domain in some cases)

[aik099]

Related discussion about that: #680

[scaytrase]

looks like mentioned test was resolved in #686. Can we advance to release?

[aik099]

looks like mentioned test was resolved in #686. Can we advance to release?

For all drivers?

[scaytrase]

May be I am missing something, but @stof referenced only zombie driver and #686 does belong to mink itself

[aik099]

Semicolon test applies to all drivers. The "wait" returns boolean test applies to zombie only, because others already comply.

[scaytrase]

Could you reference all the bugs\PRs we are waiting to track? just to not to be annoying

[aik099]

Semicolon test applies to all drivers.

• Handle the URL encoding and decoding of cookies properly MinkZombieDriver#153
• Fix the handling of cookies with semicolon MinkSelenium2Driver#227
• https://github.com/minkphp/MinkBrowserKitDriver - @stof , not sure if PR is needed
• https://github.com/minkphp/MinkSahiDriver - @stof , not sure if PR is needed

The "wait" returns boolean test applies to zombie only, because others already comply.

• Honor DriverInterface::wait() spec MinkZombieDriver#148

[weaverryan]

In this master diff since the last release, I only see 3.0 compatibility changes and some added tests: v1.7.0...master. It seems like the cookie semicolon issue (#675) - if a bug - is an existing bug - so maybe it doesn't need to be a blocker for 1.7.1 and we can have a quick tag?

Thanks!

[aik099]

• Handle the URL encoding and decoding of cookies properly MinkZombieDriver#153
• Fix the handling of cookies with semicolon MinkSelenium2Driver#227

@weaverryan , merged now.

@stof PR's related to semicolon in cookies needed for:

• https://github.com/minkphp/MinkBrowserKitDriver
• https://github.com/minkphp/MinkSahiDriver

?

[stof]

@aik099 MinkBrowserKitDriver is not affected (it was already handling them properly, hance a driver inconsistency). For SahiDriver, we will need to re-trigger a Travis build to know what is buggy in it. I will trigger it on all drivers soon (just giving time for Packagist to dump the update of the Mink version)

[stof]

@aik099 Builds are triggered for all (non-deprecated) drivers on Travis. Monitor https://travis-ci.org/minkphp to see when builds are completed (will take some time due to the quota of 5 concurrent jobs per organization on Travis)

[aik099]

Are you sure, that you triggered them? I see no yellow builds at all:

[stof]

Well, actually, I wrote the comment 1 hour ago, but forgot to push the submit button. So SahiDriver finished its build a few minutes after the comment. See when the last build has passed or failed for each driver (they are sorted by date btw)

[stof]

@aik099 I suggest doing #672 and then we can release a new version (SahiDriver should not be a blocker for the Mink release as it has not been green since years AFAIK)

[aik099]

Only 2 drivers failing and one of them is deprecated. So that leaves Sahi to be fixed. Not sure how much people are using Sahi these days considering how it it is. Maybe we can make that release (with Symfony 3.0 support) people are asking about and then at some point fix Sahi.

[stof]

@aik099 we should at least fix the cookie semicolon issue in Sahi. Other failures are already there in existing releases, so it is not making things worse

[aik099]

I've send cookie semicolon fixing PR for Sahi: minkphp/MinkSahiDriver#64

Once merged you then can release what's needed for Symfony 3 compatibility.

[stof]

1.7.1 is released. Driver releases will follow.