Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatible release #811

Closed
alexpott opened this issue Sep 21, 2021 · 10 comments
Closed

PHP 8.1 compatible release #811

alexpott opened this issue Sep 21, 2021 · 10 comments

Comments

@alexpott
Copy link
Contributor

Thanks @aik099 and @stof for all the maintainer work on this code. I was wondering if a v1.8.2 release could be made for PHP 8.1 compatibility?

Or can you let me know if there is something blocking a release that I can help with - I'm more than happy to.

@aik099
Copy link
Member

aik099 commented Sep 22, 2021

I guess the most relevant thing right now is to get the builds working again. Due to changes on Travis CI it no longer suites our needs (at least IMO) and we need to move to GitHub Actions.

As for the next steps, that block the release I have no idea. We'd better ( cc @stof ) create an umbrella task listing all the blocking issues. This way, if all tests will pass, we'll release the current release and think about dropping (or not dropping) support for an older PHP version to ease up adding support for newer PHP versions as discussed in #787 .

@alexpott
Copy link
Contributor Author

alexpott commented Oct 3, 2021

@aik099 @stof whilst I understand wishing to fix your CI looking at the difference between v1.8.1 and master - v1.8.1...master - there's not a lot there - it's mostly PHP 8.1 fixes and not doing a release makes it harder for your dependencies to test on PHP 8.1 and, therefore, make their own code compatible.

It would be really great if you could re-consider the order of priorities here as not having a Mink release that doesn't trigger deprecations on PHP 8.1.

@alexpott
Copy link
Contributor Author

alexpott commented Oct 3, 2021

Here's a PR to move to github actions - #812 - we lose PHP 5.3 testing but gain PHP 8.0 and PHP 8.1 testing.

@alexpott
Copy link
Contributor Author

alexpott commented Oct 6, 2021

@stof now that we have testing on PHP 8.1 are there any other blockers to releasing v1.9.0?

@stof
Copy link
Member

stof commented Oct 6, 2021

@alexpott I'll do the releases this evening.

Btw, we need to update https://github.com/minkphp/docs as it mentions PHP 5.3

@alexpott
Copy link
Contributor Author

alexpott commented Oct 6, 2021

@stof thanks!

I opened minkphp/docs#87 to update the docs.

@alexpott
Copy link
Contributor Author

alexpott commented Oct 8, 2021

@stof I've opened PRs against the other 2 drivers ... not sure that they are really being used much anymore especially Zombie because that one appears a bit borked..

Any chance of releases for Mink and MinkSelenium2Driver? Thanks!

@andypost
Copy link

other drivers could be managed via minkphp/driver-testsuite#33

Latest changes sounds like 1.9.x but as no API changes it could be 1.8.2

@stof
Copy link
Member

stof commented Oct 11, 2021

the release is now done for Mink (that's 1.9.0). Drivers will follow soon.

@stof
Copy link
Member

stof commented Oct 12, 2021

And drivers have all been released too

@stof stof closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants