Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure high code coverage (now: 77.08%) #51

Closed
aik099 opened this issue Dec 4, 2013 · 2 comments
Closed

Ensure high code coverage (now: 77.08%) #51

aik099 opened this issue Dec 4, 2013 · 2 comments

Comments

@aik099
Copy link
Member

aik099 commented Dec 4, 2013

Main issue: minkphp/Mink#406

Code Coverage: 77.08%
zombie_code_coverage
@stof stof mentioned this issue Mar 5, 2016
Merged
@stof
Copy link
Member

stof commented Mar 5, 2016

The coverage of the ZombieDriver class is now properly covered (mostly thanks to our enhancements in the driver testsuite). After #165, the remaining uncovered lines are about some error handling in case of Zombie triggering errors (for instance when clicking on links), which may be hard to trigger for real.

zombie_driver_coverage

Regarding the NodeJS subnamespace, most uncovered lines are either dumb getters or setters or error handling conditions (or the code in the ZombieServer class triggered when running it from inside a phar).
zombie_server_coverage

Global line coverage is over 91%

So I suggest closing this issue.

@aik099
Copy link
Member Author

aik099 commented Mar 5, 2016

OK.

@stof stof closed this as completed Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @aik099