-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: set basic auth after session start and reset #810
Comments
This came up at jhedstrom/drupalextension#597 but would make sense to fix in mink actually. |
Well, the fact that resetting the session resets the basic auth is a feature, not a bug. This is what allows to keep Behat scenarios isolated without stopping the session entirely each time (which is costly in case of webdriver as it would stop and restart the browser for instance) If the Drupal behat extension expects to be able to reset the session and having basic auth credentials preserved, I suggest that it stores them on its side and sets them again after the reset (according to the issue you linked, they seem to be doing that already for a cookie they want to keep). |
Testing sites with basic auth set became an issue for us after some extensions updates.
In particular, an extension was calling the session reset which effectively removes the pre-set basic auth credentials (header).
It would be nice if mink session would support setting basic auth credentials and use them if they are set after session start & reset.
I've created a PR that fixes the issue for us. Please take a look and let us know if it would make sense to support this.
PR: #809
The text was updated successfully, but these errors were encountered: