add relativeIndex to onDrop callback #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I think the pull request certainly solves the problem in #196, but I think I need to add support for dragging from outside the tree as well. Also, although it is an issue with the original code, it would be better to have some common code when passing indexes to onDrop and canDrop, and I felt the need to do some refactoring in this area. Therefore, I'm very sorry, but I will close this PR for now and release a new one with the corrected problem soon. |
|
@minop1205 Fair enough, I think your solution does sound better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the relativeIndex property to the
onDropcallback.Closes #196