Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livenessProbe and readinessProbe paths #81

Closed
kostyrev opened this issue Jan 10, 2019 · 1 comment
Closed

livenessProbe and readinessProbe paths #81

kostyrev opened this issue Jan 10, 2019 · 1 comment

Comments

@kostyrev
Copy link
Contributor

kostyrev commented Jan 10, 2019

-     chart: dex-k8s-authenticator-0.1.2
+     chart: dex-k8s-authenticator-1.1.1
      release: dex-k8s-authenticator
      heritage: Tiller
  spec:
    template:
      metadata:
        labels:
          app: dex-k8s-authenticator
      spec:
        containers:
        - name: dex-k8s-authenticator
          image: "mintel/dex-k8s-authenticator:1.1.0"
          livenessProbe:
            httpGet:
-             path: /
+             path: /healthz
              port: http
          readinessProbe:
            httpGet:
-             path: /
+             path: /healthz
              port: http

Is that what it should be set to by default?
curl for /healthz shows the same "Generate Kubernetes Token" page as before.

@nabadger
Copy link
Contributor

@kostyrev At the moment yes. I wanted to add a dedicated health and readiness endpoint (the readiness would probably check that Dex is accessible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants