Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile cleanup and enforce Unix line endings #80

Closed
frasergr opened this issue Jun 17, 2023 · 1 comment
Closed

Dockerfile cleanup and enforce Unix line endings #80

frasergr opened this issue Jun 17, 2023 · 1 comment

Comments

@frasergr
Copy link
Contributor

The docker entrypoint and cmd scripts are a bit redundant. The CMD dual_boot.sh script should just move to the entrypoint script and we remove the CMD altogether.

We should also enforce Unix line endings via .gitattributes as some Windows users have had problems when building the image related to line endings mismatch.
@frasergr frasergr mentioned this issue Jun 17, 2023
Merged
@timothycarambat
Copy link
Member

resolved by #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frasergr @timothycarambat