blockRevision is not changing after edit

[horacioh]

Describe the bug

Whenever you press Publish (or whatever this button is called now 😀) all the blocks you have touched would change the revision. And all these touched blocks would have the same revision (which now I think may be a bit counter-intuitive). Revision is the ID of the Change that “touched” a block.

The bug is that after editing a block the revision is not changing. I found this error when I wanted to filter conversations based on blockId and blockRevision, but it was not filtered.

To Reproduce

1. create a new publication with one block
2. edit
3. change the block text
4. publish again
5. the revision should be different, but is not.

Expected behavior

I expect the revision of a edited block to change from one version to another.

[burdiyan]

@horacioh I added a test that does what you describe, (e18879f) but it seems to be working fine: the block revision changes as expected. Can you try again, and let me know if I missed something?

[horacioh]

right now I get revisions to look like this: $LOCAL$:231. is this correct?.

It also happens that when I create a new change the revision stays the same.

[horacioh]

@burdiyan Indeed revisions does not change between versions that change the same block

mintter://bafy2bzacedbbsdlw5jj6lbl4vzqzek3nlbydabdvh4jqls2qjw7ivny7wzdcg/baeaxdiheaiqb4f56d5abwme7aezaqj76g2egevrkf645rf2lektyqa4iawq3pmi

[burdiyan]

right now I get revisions to look like this: $LOCAL$:231. is this correct?.

These are for drafts. Should never be like that for documents that are published.

[burdiyan]

@horacioh OK, apparently something is wrong here, and I think it happens on the frontend during the API -> Slate conversion.

I created one document, and this is the response from GetPublication:

{
  "version": "baeaxdiheaiqb6fap5mbdgarn5xcekcu4kihyx6pfar2vi6ng3hq2a5bdypgytgy",
  "document": {
    "id": "bafy2bzacedwj7tpx52xwpqwdpakmxrri7oopnsaukeavhc6pliwhx3j3m5cqg",
    "title": "Hello World",
    "subtitle": "",
    "author": "bahezrj4iaqacicabciqhhx2eqm73e5f5c3mgbdrfkwn77xrmbm2ai6tuebfqyhqnbjljnba",
    "create_time": "2023-03-01T18:01:10.916096Z",
    "update_time": "2023-03-01T18:01:16.224512Z",
    "publish_time": "2023-03-01T18:01:16.224512Z",
    "children": [
      {
        "block": {
          "id": "XG_0fwQo",
          "type": "statement",
          "text": "Hello World",
          "attributes": {},
          "annotations": [],
          "revision": "bafy2bzaceaprid7laizqelpnyrcqvhcsb6f7tzieovkhtjwz4gqhii6dzwezw"
        },
        "children": []
      },
      {
        "block": {
          "id": "1XwPbBZ2",
          "type": "statement",
          "text": "This is a block.",
          "attributes": {},
          "annotations": [],
          "revision": "bafy2bzaceaprid7laizqelpnyrcqvhcsb6f7tzieovkhtjwz4gqhii6dzwezw"
        },
        "children": []
      }
    ]
  }
}

Then I updated a block, published again, and this is what I get back:

{
  "version": "baeaxdiheaiqbibu63uwpx6ozyffljvzh6ywx3bp3m6q73j2unjmz7apfcog5pxi",
  "document": {
    "id": "bafy2bzacedwj7tpx52xwpqwdpakmxrri7oopnsaukeavhc6pliwhx3j3m5cqg",
    "title": "Hello World",
    "subtitle": "",
    "author": "bahezrj4iaqacicabciqhhx2eqm73e5f5c3mgbdrfkwn77xrmbm2ai6tuebfqyhqnbjljnba",
    "create_time": "2023-03-01T18:01:10.916096Z",
    "update_time": "2023-03-01T18:04:06.552576Z",
    "publish_time": "2023-03-01T18:04:06.552576Z",
    "children": [
      {
        "block": {
          "id": "XG_0fwQo",
          "type": "statement",
          "text": "Hello World",
          "attributes": {},
          "annotations": [],
          "revision": "bafy2bzaceaprid7laizqelpnyrcqvhcsb6f7tzieovkhtjwz4gqhii6dzwezw"
        },
        "children": []
      },
      {
        "block": {
          "id": "1XwPbBZ2",
          "type": "statement",
          "text": "This is now changed.",
          "attributes": {
            "revision": "bafy2bzaceaprid7laizqelpnyrcqvhcsb6f7tzieovkhtjwz4gqhii6dzwezw"
          },
          "annotations": [],
          "revision": "bafy2bzaceakanhw5ft57twobjk2noj7wfv6yl63huh62ovdklgpydzitrxl52"
        },
        "children": []
      }
    ]
  }
}

See, how in the second response the revision did actually change, but somehow the old revision appears in the attributes of the block, which shouldn't happen at all, and I think it happens during the Slate->API transformation somewhere.

[horacioh]

@burdiyan found the issue. I was not extracting revision from the values I was getting from the backend, and that's why sometimes we were storing revisions as attributes.

now it should be fixed

[burdiyan]

Closing this then?

[burdiyan]

Closing. Reopen if it's not fixed.