Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with link highlight/clicking when "_/" appears in path #1218

Closed
jmmerz opened this issue May 11, 2023 · 2 comments
Closed

Problem with link highlight/clicking when "_/" appears in path #1218

jmmerz opened this issue May 11, 2023 · 2 comments

Comments

@jmmerz
Copy link

jmmerz commented May 11, 2023

I've noticed a problem in Mintty 3.6.4 with link highlighting and clicking when the string _/ (an underscore followed by a slash) appears in the URL or filesystem path.

To reproduce:

  1. Paste the string https://www.example.com/this_/url/fails into the terminal.
  2. Hold the Control key and hover the mouse pointer over a point in the URL after the _/ (i.e. url/fails segment).

Actual behavior:

  • When hovering, only /url/fails is highlighted.
  • When I click on it, Mintty attempts to open the local directory /url/fails

Expected behavior:

  • When hovering, the entire URL should be highlighted.
  • When clicked, the entire URL https://www.example.com/this_/url/fails should be opened.

The same behavior occurs if _/ appears in a local filesystem path. I'm keeping this report concise, but am happy to provide an example with local file paths if desired.

Workaround:

If I hover the mouse over a point in the URL before any instance of _/ both highlight and clicking work as expected.


Other info

  • This works as expected in Mintty 3.6.3.
  • I have not examined the code, but I suspect this may be related to the recent changes in URLs with parentheses are not clickable #1196 to enable clicking URLs with parentheses.
  • I'm using Mintty with Cygwin version 3.4.6-1 on Windows 10. (All recent Windows patches applied and I did a full update of Cygwin modules/dependencies/etc a few days ago).
@mintty
Copy link
Owner

mintty commented May 11, 2023

This appears to be fixed in the current repository version already.

@jmmerz
Copy link
Author

jmmerz commented May 11, 2023

Thanks, just built from sources and verified it works.

Apologies for the noise, closing this issue now.

@jmmerz jmmerz closed this as completed May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants