Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

Localize the Flash On/Off button would be better #91

Closed
learning opened this issue Mar 1, 2019 · 11 comments · Fixed by #185
Closed

Localize the Flash On/Off button would be better #91

learning opened this issue Mar 1, 2019 · 11 comments · Fixed by #185
Labels
3.x Will be released in a 3.x release Feature Feature Request

Comments

@learning learning changed the title Should localize the Flash On/Off button Localize the Flash On/Off button would be better Mar 1, 2019
@angel1st
Copy link

+1 on the above. I would even suggest an easier IMO approach - rather than localize the button, it can be replaced with icon pair Flash on / off.

@gabrieleleo
Copy link

would be really awesome!!

@linguitang
Copy link

+1

3 similar comments
@hehuapei
Copy link

+1

@josephyuen
Copy link

+1

@hanlike
Copy link

hanlike commented Jul 8, 2019

+1

@masewo
Copy link

masewo commented Jul 20, 2019

+1 on the above. I would even suggest an easier IMO approach - rather than localize the button, it can be replaced with icon pair Flash on / off.

I replaced flash toggle title by two icons in my fork.

@devtronic
Copy link
Member

As mentioned here #131 (comment) I need to rewrite the platform communication. After that it's possible to use custom strings.

@devtronic devtronic added Feature Feature Request 3.x Will be released in a 3.x release labels Feb 19, 2020
@devtronic
Copy link
Member

Soon :-)
image

@devtronic
Copy link
Member

Feel free to test: #185

@devtronic devtronic linked a pull request Feb 22, 2020 that will close this issue
2 tasks
@devtronic
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x Will be released in a 3.x release Feature Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants