Redirect in route on reload

[floqqi]

I'm using ember-simple-auth for authentication. Wanted to protect admin-routes.

Following the documentation, I have something like this:

// app/routes/super-protected-route.js

import Ember from 'ember';
import { CanMixin } from 'ember-can';
import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';

export default Ember.Route.extend(AuthenticatedRouteMixin, CanMixin, {
  beforeModel() {
    this._super(...arguments);
    if (!this.can('see super-protected-thing')) {
      return this.transitionTo('index');
    }
  },
});

// app/abilities/super-protected-thing.js

import Ember from 'ember';
import { Ability } from 'ember-can';

export default Ability.extend({
  user: Ember.computed('session.currentUser', function () {
    return this.get('session.currentUser');
  }).readOnly()

  canSee: Ember.computed('user.isAdmin', function () {
    return this.get('user.isAdmin');
  }),
});

User is loaded by the SessionService:

// app/services/session.js

import Ember from 'ember';
import SessionService from 'ember-simple-auth/services/session';

export default SessionService.extend({
  store: Ember.inject.service(),

  currentUser: Ember.computed('data.authenticated.user_id', function () {
    const userID = this.get('data.authenticated.user_id');
    return this.get('store').findRecord('user', userID);
  }).readOnly()
});

If the admin is logged in and refreshes the page he get's redirected to index because the currentUser is not loaded when the SuperProtectedRoute enters beforeModel().

How to fix this?

[ssulistyo]

we had a similar problem and fixed it among some other things by moving to afterModel
#37

[floqqi]

Hm, that might work. I'm not sure I'm really comfortable with loading a model an user shouldn't have access to. I'll ditch deeper in this tomorrow and give some feedback. Thanks anyway, @ssulistyo!

[Exelord]

Thats easy :) Fetch the user before:

// app/routes/super-protected-route.js

import Ember from 'ember';
import { CanMixin } from 'ember-can';
import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';

export default Ember.Route.extend(AuthenticatedRouteMixin, CanMixin, {
  session: Ember.inject.service(),

  beforeModel() {
    this._super(...arguments);

    return this.get('service.currentUser').then(() => {
       if (!this.can('see super-protected-thing')) {
          return this.transitionTo('index');
      }
    });
  },
});

I'm closing it as it's not related to ember-can anymore, just to data management.