Location of critical value of bar scales in code has risk of being overridden in translations

[boisei0]

The critical value, in the code referenced as both “signaalwaarde” and “kritiekeWaarde”, is sourced in the locale. The default value is present in the Dutch locale. If left empty in translations, the Dutch value is used to override the translation. However, if it erroneously isn’t left empty and the value differs from the original, the interpretation strongly changes.

Should values that act as constants and don’t change upon translating be present in a locale in the first place, rather than be in file with constants? It would also improve the transparency if constants like these are in an easy place to find, rather than having to study the code in order to find them. Furthermore, storing numbers as numerical value rather than as string removes the need for Number(...) calls in the code and reduces errors caused by accidental typos slipping into the text values.

At the moment of writing, the critical value for IC admittances is located at line 102 in the Dutch locale (value 10):

nl-covid19-data-dashboard/src/locale/nl.json

Line 102 in 43b7be4

"translation": "10",

and at line 98 in the English locale (value left blank):

nl-covid19-data-dashboard/src/locale/en.json

Line 98 in 43b7be4

"translation": "",

Governance

• I've read the contributing document https://github.com/minvws/.github/blob/master/CONTRIBUTING.md
• I've read and understand the Code of Conduct https://github.com/minvws/.github/blob/master/CODE_OF_CONDUCT.md
• I understand that any contributions or suggestions I made may make it into the actual code. I've read the License https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/LICENSE.txt and the contributor license agreement https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/CLA.md

[VWSCoronaDashboard]

@boisei0

Agreed that these numeric values should ideally not live in a locale file!

If you look at an older version of the app, you can see that at some point not only the text but also all other configuration ended up in a single json files. In hindsight you could say that was premature abstraction of logic.

Not only the kritieke waarde (which has been renamed to signaal waarde) was stored there, but also constants like the min and max value and gradients of specific charts.

Long story short, we're planning to remove these constant from configuration files anyway and place them directly in the JSX.

1. Flatten the configuration file
2. Use it as an actual dictionary (now in develop!)
3. and from that point in time start moving away duplicates, configuration values and other crud from the locale files to better places where possible.

[VWSCoronaDashboard]

Configuration values ("signaalwaarde") have been removed from the locale: 48ed6cf. Thanks for reporting.

[boisei0]

This commit introduced a new issue. The “signaalwaarde” is used twice in these components. First in the bar scale, then in the plot below it.
This line will fail with the changes made, the same with the other components.

nl-covid19-data-dashboard/src/components/tiles/IntakeHospital.tsx

Line 83 in 48ed6cf

signaalwaarde={Number(text.signaalwaarde)}

[VWSCoronaDashboard]

@boisei0

You are correct!
I've made this PR to resolve that: #108

Thanks again!