Couldn't check for 24 hours incorrectly changes to display success state on retry

[TheLastProject]

Describe the bug, issue or concern

When the app hasn't been able to check for 24 hours, a notification is given. Clicking the notification brings you into the app with a warning that the app hasn't been able to check for infections for over 24 hours. Clicking the retry button instantly changes the app state back to a green checkmark with "The app is active", but after 24 hours the same error appears.

This incorrect switching to a "success" state gives a false sense of security and severely complicates troubleshooting this situation.

E.g.

To Reproduce

Steps to reproduce the behavior:

1. Wait 24 hours for the app to notify you it hasn't been able to check for 24 hours (to this day, I don't know WHY it can't)
2. Open notification
3. Click on 'Retry'
4. See incorrect success state
5. Scroll down to note the last successful check is still very long ago ("Last checked on February 22, 19:15" in my case)

Expected behavior

Retrying should cause the same "couldn't check for 24 hours" error to pop up, as the check clearly hasn't succeeded in 24 hours.

Screenshots

Impossible, app blocks creating screenshots (why? what security issue is this supposed to solve? there is no private info on the main screen of the app...)

Smartphone (please complete the following information):

• Device: Fairphone 3
• OS: Android 11
• Version: 2.4.3 build 142096-cc48c421

Additional context

This issue started appearing when I went to another network with a rather aggressive adblocker on it, so I assume my actual issue is some web URL being blocked. A list of URLs the app needs to access would be very helpful in letting me ensure my own safety, but the false reporting of the app (stating it is running successfully when it isn't) is a much more scary issue.

Governance

• I've read the contributing document https://github.com/minvws/.github/blob/master/CONTRIBUTING.md
• I've read and understand the Code of Conduct https://github.com/minvws/.github/blob/master/CODE_OF_CONDUCT.md
• I understand that any contributions or suggestions I made may make it into the actual code. I've read the License https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/LICENSE.txt and the contributor license agreement https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/CLA.md

[lpappalettera]

I will discuss your point about expected behaviour with the team to see if we can improve on that.

About screenshots. Screenshots are blocked for privacy reasons. So sensitive information like an exposure notification, cannot be captured by anyone who has access to your phone in any way.

You can find the base URL's the app is using under prod in:
https://github.com/minvws/nl-covid19-notification-app-android/blob/master/api/build.gradle