Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

CI: Update pipelines to Xcode 12.2, iOS 14.2 and iPhone 12 #63

Closed
wants to merge 6 commits into from

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Nov 7, 2020

Updates the build.yml Azure pipeline to use:

  • Xcode 12.2
  • iOS 14.2
  • iPhone 12 (as simulation target)

Using Xcode 12.2 improves support for the iPhone 12 series and devices on iOS 14.2.

Also updates the CI.yml Github Actions workflow to target iPhone 12.

Updates the build.yml pipeline to use:
 - Xcode 12.2
 - iOS 14.2
 - iPhone 12 (as simulation target)
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2020

CLA assistant check
All committers have signed the CLA.

Updates the GitHub Actions workflow to target iPhone 12 for CI tests
@EwoutH EwoutH changed the title CI: Update build.yml to Xcode 12.2, iOS 14.2 and iPhone 12 CI: Update pipelines to Xcode 12.2, iOS 14.2 and iPhone 12 Nov 7, 2020
@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 7, 2020

This PR also fixes the GitHub Actions CI, which is currently failing.

Please squash when merging.

@sbarow sbarow mentioned this pull request Nov 9, 2020
@roelspruit
Copy link
Contributor

Hey. Thanks for this PR. We're currently preparing a new release and would rather not mess with pipelines during this process, especially because this change might also impact our tests (snapshot tests are very susceptible to breaking when switching to another version of iOS for testing. Therefore we will temporarily hold off on merging this PR. I expect we can merge it within 1 or 2 weeks.

@EwoutH EwoutH marked this pull request as draft November 9, 2020 14:48
@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 9, 2020

@roelspruit Sounds good, marked it as draft right now. Please hit me up when you're ready!

@roelspruit
Copy link
Contributor

Hi. We mirrored this PR to our internal repository and merged it in. This should have also marked this PR as "merged" but I guess it didn't because it was marked as draft. Anyway, your code made it in! Thank you very much for the work. It's so nice to see that little green checkmark on GitHub again ;) I'm going to close this PR now.

@roelspruit roelspruit closed this Dec 14, 2020
@EwoutH
Copy link
Contributor Author

EwoutH commented Dec 14, 2020

You’re welcome, thanks for merging!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants