Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Sometimes Doesn't Work When rewrite_urls = 0 #1

Closed
hartenthaler opened this issue May 11, 2022 · 5 comments
Closed

Module Sometimes Doesn't Work When rewrite_urls = 0 #1

hartenthaler opened this issue May 11, 2022 · 5 comments

Comments

@hartenthaler
Copy link

I just installed your module on my test server. There are four trees. The module is visible in the control panel. No error.

No function. When I log out and log in, I see "MyPage", not the page of any tree.

@miqrogroove
Copy link
Owner

I checked some of my other code hacks and couldn't reproduce that issue with my one tree config. I will try adding a 2nd tree and see what happens with it.

@miqrogroove
Copy link
Owner

miqrogroove commented May 12, 2022

It still works here on my server with 2 trees. So I need more info. Could you describe your webtrees version, Family Tree Home Page version, do you have rewrite_urls in the config file, and are there any special privacy settings, such as guests can't see any trees? Any other custom modules? Also, if you could tell me anything about the address under the Sign In link, which sometimes ends with %2Fmy-page depending on the current page viewed.

One theory I have is the lack of rewrite_urls, as seen on the demo site, causes the Sign In URL to end with %252Fmy-page instead of %2Fmy-page

If you can confirm your test server is doing the same, then that might be the bug in my module.

@miqrogroove miqrogroove added question Further information is requested and removed question Further information is requested labels May 12, 2022
@miqrogroove
Copy link
Owner

I was able to reproduce that bug. Here are the criteria:

  • Must have at least one tree visible to guests.
  • Must have rewrite_urls = "0"
  • Must click the Sign In link from the visitor's home/tree page.

Any other combination of settings or inputs would not trigger this bug. It was tricky!

@miqrogroove miqrogroove changed the title No function Module Sometimes Doesn't Work When rewrite_urls = 0 May 12, 2022
@hartenthaler
Copy link
Author

Sorry for the late answer. I was busy, today. rewrite_urls was not set, so I assume it is used as "0". There is a tree visible to guests. And I signed in from the default tree home page. Now I will test your new version.

@hartenthaler
Copy link
Author

Success! Now it works like expected. Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants