Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation not found on PVCs is logged as ERROR #109

Open
mdnfiras opened this issue Jun 7, 2022 · 0 comments
Open

Annotation not found on PVCs is logged as ERROR #109

mdnfiras opened this issue Jun 7, 2022 · 0 comments

Comments

@mdnfiras
Copy link

mdnfiras commented Jun 7, 2022

k8s-snapshots logs an annotation not found entry for every PVC that doesn't have the annotation with a severity of ERROR, which produces so much noise.

I think that having some PVCs without the annotation should be okay, and at most logged as INFO.
This is already the case for PVs as you can see here: https://github.com/miracle2k/k8s-snapshots/blob/master/k8s_snapshots/core.py#L227

fix proposal here: #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant