Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google pd.csi.storage.gke.io StorageClass provisioner not supported #110

Open
igoooor opened this issue Jul 8, 2022 · 0 comments
Open

Comments

@igoooor
Copy link

igoooor commented Jul 8, 2022

According to https://github.com/miracle2k/k8s-snapshots/blob/master/k8s_snapshots/backends/google.py#L147
it only supports kubernetes.io/gce-pd StorageClass provisioner.
But now GKE also has pd.csi.storage.gke.io which does not comply with the condition bool(volume.obj['spec'].get('gcePersistentDisk')) from line 147
Instead the check could be (bear with me I never wrote python):
bool(volume.obj['spec'].get('gcePersistentDisk')) or bool(volume.obj['spec'].get('csi'))
Maybe the check can be improved, here is the content of that key:

  csi:
    driver: pd.csi.storage.gke.io
    fsType: ext4
    volumeAttributes:
      storage.kubernetes.io/csiProvisionerIdentity: ..............
    volumeHandle: ..........

Again, I don't know python so... but maybe we could check that spec.csi.driver == "pd.csi.storage.gke.io"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant