Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosing a custom YouTube video to download #103

Closed
Crilum opened this issue Feb 8, 2022 · 1 comment
Closed

Choosing a custom YouTube video to download #103

Crilum opened this issue Feb 8, 2022 · 1 comment

Comments

@Crilum
Copy link

Crilum commented Feb 8, 2022

I think it would be useful to be able to specify the YouTube song to download, because in some cases, the YouTube video freyr chooses doesn't have the highest quality.

Try downloading Owl City's 'Gold': freyr spotify:track:5pBCrF0gXKLZXj77BdJNh2, then listen carefully to the downloaded song, and the song on Spotify, and compare the two. There are some noise/artifacts in the downloaded song. This isn't the fault of freyr though, it's just the way the YouTube video is.

I think it would be pretty easy to implement a flag for downloading a custom YouTube video.
Example of a flag that specifies a custom Youtube video:

freyr spotify:track:5pBCrF0gXKLZXj77BdJNh2 --youtube-video="https://www.youtube.com/watch?v=hSkjIT3jsQE"

I would try to make a PR, but I don't know any JavaScript.. 🙄

@miraclx
Copy link
Owner

miraclx commented Feb 9, 2022

Yeah, this issue has already been identified (See #11) but the feature hasn't been implemented.

The problem with adding a flag like --youtube-video is freyr supports downloading multiple tracks at once, even whole albums, artists or complete playlists.

We could consider introducing a field like -M, --source-map <spec> or --source-map <file>

If it's a spec, it can be like -M "spotify:track:5pBCrF0gXKLZXj77BdJNh2|youtube:hSkjIT3jsQE"
if it's a file, it can be like --source-map ./freyr_map.json and its content can be;

{
  "spotify": {
    "5pBCrF0gXKLZXj77BdJNh2": "https://www.youtube.com/watch?v=hSkjIT3jsQE"
  }
}

Closing in favor of #11, see my extended comment at #11 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants