Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected and actual output do not stand enough in the output #252

Closed
christophe-riolo opened this issue May 30, 2020 · 1 comment · Fixed by #246
Closed

Expected and actual output do not stand enough in the output #252

christophe-riolo opened this issue May 30, 2020 · 1 comment · Fixed by #246
Assignees

Comments

@christophe-riolo
Copy link

Hello, I am new to Alcotest and I have been perplexed when confronted with this output:

ASSERT Returns error
[failure] Error Returns error: expecting
Connect Error: connection error., got
Connect Error: connection error.

It took me way longer than I would like to admit to realise that the last dot was part of the punctuation of the sentence and I was wondering why Connect Error: connection error. was different from Connect Error: connection error..
I think it would be clearer to separate more clearly the outputs, for instance:

ASSERT Returns error
[failure] Error Returns error
Expected:
Connect Error: connection error.
Actual:
Connect Error: connection error
@craigfe
Copy link
Member

craigfe commented May 30, 2020

Thanks for the suggestion!

We actually have an open PR that makes an almost identical change (#246) and a WIP one that takes this a step further by highlighting the component of the output that is different (#247). I hope those will solve your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants