Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers/GC: consider using buffered writes to the suffix file (eg ocaml out_channel, or our own version) #1841

Closed
tomjridge opened this issue May 11, 2022 · 1 comment
Labels
feature/layered-store Related to the Layered Store

Comments

@tomjridge
Copy link
Contributor

tomjridge commented May 11, 2022

Currently the layers code handles append by issuing a pwrite. It may well be that using a buffered output (eg ocaml's out_channel, or our own version) would be much faster, at least in certain circumstances.

This issue arose because layers/GC snapshot import is still a bit slower than main branch snapshot import, and the likely cause is that layers issues direct syscalls whereas it could instead use buffered output.

@tomjridge tomjridge added the feature/layered-store Related to the Layered Store label May 11, 2022
@Ngoguey42
Copy link
Contributor

Buffer writes are included in the gc branch, from the apprend only module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/layered-store Related to the Layered Store
Projects
None yet
Development

No branches or pull requests

2 participants