Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irmin-mirage-git: support mirage-kv.5.0.0 #2083

Closed
metanivek opened this issue Sep 9, 2022 · 1 comment · Fixed by #2256
Closed

irmin-mirage-git: support mirage-kv.5.0.0 #2083

metanivek opened this issue Sep 9, 2022 · 1 comment · Fixed by #2256
Assignees
@metanivek
Labels
good-first-issue A problem for Irmin beginners

Comments

@metanivek
Copy link
Member

New functions were added to Mirage_kv.(RO|RW) in 5.0.0. See mirage/mirage-kv#28.

I don't know how well these fit a git-based KV store, so we could either try to implement them hackily (ie reading entire values) or simply failing as not supported operations.
@metanivek metanivek changed the title irmin-mirage-git: support mirage-kv 5.0.0 irmin-mirage-git: support mirage-kv.5.0.0 Sep 9, 2022
@metanivek
Copy link
Member Author

As a reference, git-kv reads the entire value for a key for these new functions.

@metanivek metanivek added the good-first-issue A problem for Irmin beginners label Feb 15, 2023
@metanivek metanivek mentioned this issue Feb 15, 2023
Merged
@metanivek metanivek self-assigned this Jun 5, 2023
@metanivek metanivek mentioned this issue Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metanivek metanivek

Labels
good-first-issue A problem for Irmin beginners
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

irmin-mirage-git: update for latest versions of mirage-kv metanivek/irmin
1 participant
@metanivek