Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP configuration --v4 ip/mask instead of --ip X --netmask Y #649

Closed
hannesm opened this issue Nov 3, 2016 · 4 comments
Closed

IP configuration --v4 ip/mask instead of --ip X --netmask Y #649

hannesm opened this issue Nov 3, 2016 · 4 comments
Assignees
Milestone

Comments

@hannesm
Copy link
Member

hannesm commented Nov 3, 2016

instead of using V4[V6].ip & netmask (read: two command-line arguments), use a single one: ip/netmask). This leads to fewer potential error conditions (what happens if a is provided, but not b), and is pretty standard.

The gateway can be a separate key since it is optional anyways (it is perfectly good to have a unikernel without a default gateway -- e.g. a local syslog collector, a DHCP server, ...).

Work only to be done once #643 is in to avoid conflicts and needless rebasing.

@hannesm hannesm self-assigned this Nov 3, 2016
@hannesm
Copy link
Member Author

hannesm commented Nov 3, 2016

(but default gateway that isn't on the network should be a runtime error, probably)

should error as early as we can!

@yomimono
Copy link
Contributor

yomimono commented Nov 3, 2016

Is this actually the right thing to do for ipv6? See the last couple comments in #557

@hannesm hannesm added this to the mirage 3.0.0 milestone Nov 22, 2016
@yomimono
Copy link
Contributor

The current behavior came in with #643 , which addressed in part #557 .

@mato
Copy link
Contributor

mato commented Nov 23, 2016

The current behaviour is actually two arguments, --ip=IP and --network=NETWORK/MASK.

This syntax violates POLA and is unnecessarily hard to implement in things like docker-unikernel-runner, so I'd like to bump this issue. Can we change to just --ip=IP/MASK please? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants