New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't generate xen configuration files per-unikernel (by default? at all?) #893
Comments
I agree that these files bring too much clutter and that they are not necessary in general for the experienced user; Maybe adding an option to generate these files on demand would be enough? (e.g. using |
I don't mind if these files aren't autogenerated as long as the docs still explain how to write them and have an example or two. The main thing I find useful about these files is that they remind me of the file syntax which I can never remember. |
how about a when reworking mirage for the 3.0 release I only for the xen (and maybe qubes) target have these files being generated, and see value in automatically generating these stubs to be modified by the developer at a later point. |
It sounds like something nonspecific would be sufficient. For example, rather than spitting out the header with the unikernel name, to say "put the filename of the compiled unikernel here, e.g. /home/user/myproject/unikernelname.xen". Then There's a PR to remove generation entirely for |
The
main.xl
(andmain.xl.in
, andlibvirt.xml
) files are currently generated (and any existing ones replaced) on any call tomirage configure -t xen
(and alsomirage configure -t qubes
, which is probably a bug).I've personally found this to be an annoyance more often than it has been a help even in the case where I am running on a vanilla Xen machine and therefore can use the configuration, which is a rare circumstance. It was helpful to me when I was new to Mirage and Xen (with which I was also unfamiliar) was the only non-UNIX backend, but I think very few people in that situation in 2018CE will be running unikernels on vanilla Xen where the user is in control of dom0 - I think the more common configuration, by far, is running via solo5, QubesOS, or (a distant third) on the public cloud.
Leaving the creation of these files to the user would allow us to simplify
lib/mirage.ml
considerably.The text was updated successfully, but these errors were encountered: