More robust handling of paths beginning with //

[zoggy]

Hello,

When an uri such as http://localhost//foo/bar is requested, Uri.of_string is used on the requested path, i.e. //foo/bar, which returns an uri with path /bar, because it handles the whole string as a uri. This should be parsed as a path, to handle "incorrect" paths beginning with "//".

The call to Uri.of_string is here: https://github.com/mirage/ocaml-cohttp/blob/master/lib/request.ml#L113

[dsheets]

Indeed you are correct. I am preparing a patch now.

[dsheets]

#309 fixes this issue. When that PR is merged, this issue will close. Thanks for reporting the problem!

[zoggy]

The fix does not seem to handle query params correctly, i.e. with the following url:

http://localhost/test?formula=foo

the path obtained with Uri.path is /test%3Fformula=foo instead of "/test".

[dsheets]

Indeed. :-( Sorry about that. It's the same problem as mirage/irmin#187 (comment).

[zoggy]

I'm trying to fix it.

[zoggy]

Here is a PR: #317
"make test" was OK and it seems to fix my problem.