Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StopClient() is causing crash #68

Closed
Lymdun opened this issue Mar 6, 2020 · 2 comments
Closed

StopClient() is causing crash #68

Lymdun opened this issue Mar 6, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Lymdun
Copy link
Member

Lymdun commented Mar 6, 2020

Describe the bug
When calling StopClient(), the entire game is crashing. Also the client isn't properly disconnected from the server.

Expected behavior
Client should be properly disconnected from the server, and no crash should be involved.

@Lymdun Lymdun added the bug Something isn't working label Mar 6, 2020
@Lymdun
Copy link
Member Author

Lymdun commented Mar 8, 2020

Stacktrace:

StackOverflowException: The requested operation caused a stack overflow.
UnityEngine.Object.IsNativeObjectAlive (UnityEngine.Object o) (at C:/buildslave/unity/build/Runtime/Export/Scripting/UnityEngineObject.bindings.cs:156)
UnityEngine.Object.CompareBaseObjects (UnityEngine.Object lhs, UnityEngine.Object rhs) (at C:/buildslave/unity/build/Runtime/Export/Scripting/UnityEngineObject.bindings.cs:135)
UnityEngine.Object.op_Inequality (UnityEngine.Object x, UnityEngine.Object y) (at C:/buildslave/unity/build/Runtime/Export/Scripting/UnityEngineObject.bindings.cs:396)
UnityEngine.Events.BaseInvokableCall.AllowInvoke (System.Delegate delegate) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent/UnityEvent.cs:133)
UnityEngine.Events.InvokableCall.Invoke () (at C:/buildslave/unity/build/Runtime/Export/UnityEvent/UnityEvent.cs:165)
UnityEngine.Events.UnityEvent.Invoke () (at C:/buildslave/unity/build/Runtime/Export/UnityEvent/UnityEvent/UnityEvent_0.cs:58)
Mirror.Tcp.TcpTransport.<Awake>b__5_4 () (at Assets/Mirror/Runtime/Transport/Tcp/TcpTransport.cs:33)
Mirror.Tcp.Client.Disconnect () (at Assets/Mirror/Runtime/Transport/Tcp/Client.cs:89)
Mirror.Tcp.TcpTransport.ClientDisconnect () (at Assets/Mirror/Runtime/Transport/Tcp/TcpTransport.cs:54)
Mirror.NetworkConnectionToServer.Disconnect () (at Assets/Mirror/Runtime/NetworkConnectionToServer.cs:29)
Mirror.NetworkClient.Disconnect () (at Assets/Mirror/Runtime/NetworkClient.cs:196)
Mirror.NetworkManager.StopClient () (at Assets/Mirror/Runtime/NetworkManager.cs:603)
Mirror.NetworkManager.OnClientDisconnect (Mirror.NetworkConnection conn) (at Assets/Mirror/Runtime/NetworkManager.cs:1359)
Mirror.NetworkManager.OnClientDisconnectInternal (Mirror.NetworkConnection conn, Mirror.DisconnectMessage msg) (at Assets/Mirror/Runtime/NetworkManager.cs:1184)
Mirror.MessagePacker+<>c__DisplayClass6_0`2[T,C].<MessageHandler>b__0 (Mirror.NetworkConnection conn, Mirror.NetworkReader reader, System.Int32 channelId) (at Assets/Mirror/Runtime/MessagePacker.cs:133)
Mirror.NetworkConnection.InvokeHandler (System.Int32 msgType, Mirror.NetworkReader reader, System.Int32 channelId) (at Assets/Mirror/Runtime/NetworkConnection.cs:215)
Mirror.NetworkConnection.InvokeHandler[T] (T msg, System.Int32 channelId) (at Assets/Mirror/Runtime/NetworkConnection.cs:243)
Mirror.NetworkClient.OnDisconnected () (at Assets/Mirror/Runtime/NetworkClient.cs:150)
UnityEngine.Events.InvokableCall.Invoke () (at C:/buildslave/unity/build/Runtime/Export/UnityEvent/UnityEvent.cs:166)
UnityEngine.Events.UnityEvent.Invoke () (at C:/buildslave/unity/build/Runtime/Export/UnityEvent/UnityEvent/UnityEvent_0.cs:58)
Mirror.Tcp.TcpTransport.<Awake>b__5_4 () (at Assets/Mirror/Runtime/Transport/Tcp/TcpTransport.cs:33)
Mirror.Tcp.Client.Disconnect () (at Assets/Mirror/Runtime/Transport/Tcp/Client.cs:89)
Mirror.Tcp.TcpTransport.ClientDisconnect () (at Assets/Mirror/Runtime/Transport/Tcp/TcpTransport.cs:54)
Mirror.NetworkConnectionToServer.Disconnect () (at Assets/Mirror/Runtime/NetworkConnectionToServer.cs:29)
Mirror.NetworkClient.Disconnect () (at Assets/Mirror/Runtime/NetworkClient.cs:196)
Mirror.NetworkManager.StopClient () (at Assets/Mirror/Runtime/NetworkManager.cs:603)
Mirror.NetworkManager.OnClientDisconnect (Mirror.NetworkConnection conn) (at Assets/Mirror/Runtime/NetworkManager.cs:1359)
Mirror.NetworkManager.OnClientDisconnectInternal (Mirror.NetworkConnection conn, Mirror.DisconnectMessage msg) (at Assets/Mirror/Runtime/NetworkManager.cs:1184)
Mirror.MessagePacker+<>c__DisplayClass6_0`2[T,C].<MessageHandler>b__0 (Mirror.NetworkConnection conn, Mirror.NetworkReader reader, System.Int32 channelId) (at Assets/Mirror/Runtime/MessagePacker.cs:133)
Mirror.NetworkConnection.InvokeHandler (System.Int32 msgType, Mirror.NetworkReader reader, System.Int32 channelId) (at Assets/Mirror/Runtime/NetworkConnection.cs:215)
Mirror.NetworkConnection.InvokeHandler[T] (T msg, System.Int32 channelId) (at Assets/Mirror/Runtime/NetworkConnection.cs:243)
Mirror.NetworkClient.OnDisconnected () (at Assets/Mirror/Runtime/NetworkClient.cs:150)
UnityEngine.Events.InvokableCall.Invoke () (at C:/buildslave/unity/build/Runtime/Export/UnityEvent/UnityEvent.cs:166)
UnityEngine.Events.UnityEvent.Invoke () (at C:/buildslave/unity/build/Runtime/Export/UnityEvent/UnityEvent/UnityEvent_0.cs:58)
...

@paulpach
Copy link
Contributor

paulpach commented Mar 8, 2020

fixed in f584388

@paulpach paulpach closed this as completed Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants