Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing comments of YAML files #337

Closed
alexanderadam opened this issue Feb 6, 2023 · 1 comment
Closed

Showing comments of YAML files #337

alexanderadam opened this issue Feb 6, 2023 · 1 comment

Comments

@alexanderadam
Copy link

So it seems that Accent shows comments now for Gettext and Simon suggested to open new issues for other formats.
So here's the one for YAML.

In theory there are two possibilities to add comments

en:
  foo: "Foo" # this is 'Foo'

and

en:
  # this is 'Bar'
  bar: "Bar"

but the second one isn't necessarily clear. It could also be that someone commented out a line.
The comment behind the value is directly associated to key and value.

Hence I would propose only using the comment of the same line.

I don't know whether fast_yaml even supports parsing comments and I guess some open issues may take a while but maybe we're lucky? 😉

@simonprev
Copy link
Member

Since the fast_yaml is not working on my M1 machine, we are currently only supporting the existing implementation and not fixing/adding features to the YAML format 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants