Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator and Proofreader #393

Closed
RappyTV opened this issue Dec 1, 2023 · 7 comments
Closed

Translator and Proofreader #393

RappyTV opened this issue Dec 1, 2023 · 7 comments

Comments

@RappyTV
Copy link

RappyTV commented Dec 1, 2023

I would appreciate a feature where "Translator" and "Proofreader" are two seperate roles so when a normal translator changes a string, it's not deployed directly and has to first be approved by a Proofreader.

@simonprev
Copy link
Member

Just pushed a new role "translator" and a new state "translated" on a strings that is made true when the translation is saved in the UI

@RappyTV
Copy link
Author

RappyTV commented Dec 22, 2023

@simonprev I really appreciate the effort but the "Reviews tab" is just gone after the update and I don't think it's supposed to be this way.
As an admin: https://media.rappytv.com/u/opera_1Y3y5Q9N0T.png
As a translator & as a reviewer: https://media.rappytv.com/u/firefox_DfuMEUmsyb.png

@simonprev
Copy link
Member

Oh yeah sorry, it was a bug in v1.19.8 but it’s fixed in v1.19.9 😄

@RappyTV
Copy link
Author

RappyTV commented Dec 22, 2023

tyvm ❤️

@RappyTV
Copy link
Author

RappyTV commented Dec 22, 2023

Translators and reviewers still don't have access to the "Review tab". Admins do

@simonprev
Copy link
Member

simonprev commented Dec 22, 2023

Oh you’re right, fixed in 6b9f7c3 and building right now in v1.19.10

@RappyTV
Copy link
Author

RappyTV commented Dec 22, 2023

W

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants