-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support umbrella apps #1
Conversation
lib/credo_filename_consistency/check/consistency/filename_consistency.ex
Show resolved
Hide resolved
This is awesome! 🎉 If you have time to add both Elixir versions (1.7 and 1.8) to If you don’t have time, no worries, I’ll merge it right now and edit Thank you! |
53ebd91
to
26c6deb
Compare
It works with older Elixir just fine. :-)
Just a harmless cleanup.
This is great, thank you Tomáš! I’ll cut the 0.2.0 right after this. |
Thanks for merging. BTW, I'm new to Elixir and its community and I've been wondering if merging via squashing is the standard here because this is my second Elixir-related PR that was merged in that way and it's making me somewhat uncomfortable as there's now a squashed commit authored by me in some git history somewhere and I always strived to make proper commits that don't mix unrelated changes... But if this is standard in the Elixir community, I can live with that, I guess. :-) |
I think it’s just a coincidence :)
This is just my personal preference as an open-source project maintainer. I always try to keep a clean git history in the Thank you for contributing! |
Okay, thanks for clarifying. :-) |
Fix root path detection for umbrella apps, plus two small cleanups.