Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite scroll? #11

Closed
lmhung opened this issue Nov 10, 2013 · 5 comments
Closed

Infinite scroll? #11

lmhung opened this issue Nov 10, 2013 · 5 comments

Comments

@lmhung
Copy link

lmhung commented Nov 10, 2013

How do I add Paul Irish infinite scroll with this plugin?

@dpellenwood
Copy link

Ditto. I'd like to be able to use this plugin along with Infinite Scroll. When I fire this plugin as a callback for Infinite Scroll, All I get is the loading image.

@x2q
Copy link

x2q commented Feb 18, 2014

+1

@mikuel
Copy link

mikuel commented Mar 5, 2014

This feature would be really nice.

@miromannino
Copy link
Owner

Try the 3.0.0-RC2, it is now stateful and can manage these scenarios. I implemented an example of infinite scroll using the Paul Irish's plugin. Tell me if there are some bugs or something to fix

@peterlevi
Copy link

Hello Miro, thumbs up on a really nice project!
To the point: current version (3.2.0) does not play well with infinite scroll - the bug is present even in the infinite scroll example in docs. Most often (but not always), it hangs when infinite scroll triggers and tries to add images - the three dots (".justified-gallery > .spinner") remain visible and moving on screen.

Here are some of the errors in console:

Failed to load resource: the server responded with a status of 404 (Not Found) http://localhost:4000/static/Justified-Gallery/docs/undefined
Uncaught TypeError: Cannot read property '0' of null jquery.justifiedgallery.js:98
Uncaught TypeError: Cannot read property '0' of null jquery.justifiedgallery.js:98
Uncaught TypeError: Cannot read property '0' of null jquery.justifiedgallery.js:98

I believe one of the problems is the infinite scroll "loading images" spinner that Infinite Scroll uses - I think justified gallery does not properly exclude it when finding images and problems come from there, but I'm not sure if this is the only issue - when I tried to get around this in a simple way by skipping this image, this fixed the 404 error above but didn't fix the whole problem.

BTW, another issue with this example is that it references "dist/css/jquery.justifiedgallery.css", while the real file is "dist/css/jquery.justifiedGallery.css", and same problem with the link to the js file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants