Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roslyn Incremental compiler issue #101

Closed
konstantin890 opened this issue Nov 2, 2018 · 1 comment
Closed

Roslyn Incremental compiler issue #101

konstantin890 opened this issue Nov 2, 2018 · 1 comment

Comments

@konstantin890
Copy link
Contributor

Describe the bug
Starting a project/building it or entering playmode drops warning when using the Roslyn incremental compiler (v0.0.42) in Unity 2018.2.14f (same with 2018.1+). Even with this warning all the functionality of Mirror seems to be fine

Unable to delete file Library/ScriptAssemblies/Assembly-CSharp.pdb: Sharing violation on path Library/ScriptAssemblies/Assembly-CSharp.pdb UnityEngine.Debug:LogWarning(Object) Mirror.Weaver.Weaver:Weave(String, IEnumerable1, IAssemblyResolver, String, String, String)
Mirror.Weaver.Weaver:WeaveAssemblies(IEnumerable1, IEnumerable1, IAssemblyResolver, String, String, String)
Mirror.Weaver.Program:Process(String, String, String, String[], String[], IAssemblyResolver, Action1, Action1)
Mirror.Weaver.<>c:<.cctor>b__0_0(String, CompilerMessage[])
UnityEditor.Scripting.ScriptCompilation.EditorCompilationInterface:TickCompilationPipeline(EditorScriptCompilationOptions, BuildTargetGroup, BuildTarget)`

To Reproduce
Just put Mirror into an empty project with the Roslyn Incremental compiler enabled (2018.1+/0.0.42)
Installation instructions for the compiler: https://goo.gl/6FmREG (first post)

Expected behavior
The warning not to appear

Desktop:

  • OS: Windows
  • Build target: Standalone
  • Unity version: 2018.1+ (not tested in the 2018.3 beta)
  • Latest Mirror 495
@paulpach
Copy link
Contributor

paulpach commented Nov 2, 2018

This issue is handled fine in Mirror. We handle it and just print the warning, you can ignore the warning

This is a duplicate of #29

@paulpach paulpach closed this as completed Nov 2, 2018
James-Frowen pushed a commit to James-Frowen/Mirror that referenced this issue Mar 31, 2020
* Initialize NM only once during Start

* fix tests, don't start on headless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants