Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkManager not designed well for inheritance. #69

Closed
shinyclef opened this issue Oct 14, 2018 · 2 comments
Closed

NetworkManager not designed well for inheritance. #69

shinyclef opened this issue Oct 14, 2018 · 2 comments
Labels
released

Comments

@shinyclef
Copy link

When inheriting from NetworkManager (e.g. MyNetworkManager : NetworkManager), the base network manager's Awake function is not called, which is suppose to call private InitializeSingleton and public InitializeTransport.

Steps to reproduce the behaviour:

  1. Create class MyNetworkManager : NetworkManager.
  2. Attach to gameobject.

Expected behavior
Network transport and singleton should initialise. "Thank you for using Mirror" message should be logged.

Using Release: mirror-397

I solved this myself for the time being by calling base.awake via reflection in my own awake.
@miwarnec
Copy link
Collaborator

Thanks for reporting. Fixed it. You can now call base.Awake() and base.OnValidate() and so on.

@miwarnec
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

James-Frowen pushed a commit to James-Frowen/Mirror that referenced this issue Mar 31, 2020
@Lymdun
fix: attributes causing a NRE (MirrorNetworking#69)
fc99c67 
* Fix weaver check

* Add tests
James-Frowen pushed a commit to James-Frowen/Mirror that referenced this issue Mar 31, 2020
@semantic-release-bot
chore(release): 15.0.4 [skip ci]
3f15cb7 
## [15.0.4](MirageNet/Mirage@15.0.3-master...15.0.4-master) (2020-03-08)

### Bug Fixes

* attributes causing a NRE ([MirrorNetworking#69](MirageNet/Mirage#69)) ([fc99c67](MirageNet/Mirage@fc99c67))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shinyclef @miwarnec