Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember selected subtitle language #206

Closed
1 task done
boonsboos opened this issue Jan 21, 2024 · 0 comments · Fixed by #216
Closed
1 task done

Remember selected subtitle language #206

boonsboos opened this issue Jan 21, 2024 · 0 comments · Fixed by #216
Assignees
Labels
enhancement New feature or request

Comments

@boonsboos
Copy link

Describe your suggested feature

Currently when you start playback of an episode and select the subtitle, it only remembers the subtitle language while it remains focused. e.g: going back to the series menu will reset the subtitle language to none. Same goes for going to the next episode.

How to reproduce:

  1. Start playing a show
  2. Change the subtitles language to anything except none
  3. Change episodes or otherwise stop watching the current episode
  4. Go back to that episode
    You will now see that the subtitles have been defaulted back to none.

I understand that defaulting to no subtitles is a very safe default since subtitles are not always available but I am of the opinion that this is a valuable QoL feature.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
@boonsboos boonsboos added the enhancement New feature or request label Jan 21, 2024
@boonsboos boonsboos changed the title Remember selected subtitle Remember selected subtitle language Jan 21, 2024
@MiaoMint MiaoMint self-assigned this Jan 27, 2024
@MiaoMint MiaoMint linked a pull request Jan 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants