Incorrect default value for queries with @include directive

[salmannotkhan]

First of all, I loved the project. It has everything that anyone can expect.

Recently I ran into an issue, When the field name is in camelCase and uses @include directive the generated pydantic code doesn't generate proper default value (None)

I have used https://graphqlzero.almansi.me/api schema for testing purpose

queries.graphql:

query foo{
  postData: post (id: 1) @include(if: true)  {
    id
  }
}

generated pydantic code:

from typing import Optional

from pydantic import Field

from .base_model import BaseModel


class Foo(BaseModel):
    post_data: Optional["FooPostData"] = Field(alias="postData")


class FooPostData(BaseModel):
    id: Optional[str]

post_data should be Field(None, alias="postData") because it's optional.

[salmannotkhan]

Issue seems to be here: https://github.com/mirumee/ariadne-codegen/blob/main/ariadne_codegen/client_generators/result_types.py#L391-L418

We are not assigning positional arg for default or default keyword arg. I have fixed it by adding default kwarg in there. Should I create PR for the same?

[salmannotkhan]

I think we should also fix the generate_pydantic_field method. It currently only takes keywords arguments. It should accept positional arguments also.

What do you guys think?

[salmannotkhan]

@rafalp Can you take a look at this issue? I have already fixed it in local repo, I can create PR for the same.

[ori-lb]

Is this issue fixed on master? encountering the same problem.
@salmannotkhan did you raise a pr eventually?

[salmannotkhan]

Waiting for @rafalp's permission.

[bombsimon]

I don't think you need permission to create a PR. I would suggest just creating it so it can be reviewed when maintainers have the time and while waiting hopefully others will see it and be able to test it or spot things that might require further changes.