Merge pull request #4561 from mirumee/fix-validating-menu-items

Fix validating menu items inputs
saleor · Jul 30, 2019 · 94314bf · 94314bf
2 parents d9a4ecb + c1b1a43
commit 94314bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/saleor/graphql/menu/mutations.py b/saleor/graphql/menu/mutations.py
@@ -129,8 +129,8 @@ def _validate_menu_item_instance(
     cleaned_input: dict, field: str, expected_model: Model
 ):
     """Check if the value to assign as a menu item matches the expected model."""
-    if field in cleaned_input:
-        item = cleaned_input[field]
+    item = cleaned_input.get(field)
+    if item is not None:
         if not isinstance(item, expected_model):
             msg = (
                 f"Enter a valid {expected_model._meta.verbose_name} ID "

diff --git a/tests/api/test_menu.py b/tests/api/test_menu.py
@@ -20,6 +20,10 @@ def test_validate_menu_item_instance(category, page):
     with pytest.raises(ValidationError):
         _validate_menu_item_instance({"category": page}, "category", Category)
 
+    # test that validation passes with empty values passed in input
+    _validate_menu_item_instance({}, "category", Category)
+    _validate_menu_item_instance({"category": None}, "category", Category)
+
 
 def test_menu_query(user_api_client, menu):
     query = """