Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for moving orderSettings to Channel #11645

Merged
merged 2 commits into from Feb 8, 2023

Conversation

kadewu
Copy link
Member

@kadewu kadewu commented Jan 4, 2023

Port of #11713

Issue: #11337

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations
  • Documentation needs to be updated

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@db-queries
Copy link

db-queries bot commented Jan 4, 2023

Here is the report for caa3040 (saleor:move-order-settings-to-channel-3.9)
Missing base report (53088dc). The results couldn't be compared.

No differences were found.

# saleor.graphql.accountbenchmark account
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  addresses for federation query count                                    	          9	          9	              2
  customers query                                                         	         48	         48	              0
  delete staff members                                                    	         37	         37	              1
  query staff user                                                        	         18	         18	              3
  staff create                                                            	         23	         23	              3
  staff update groups and permissions                                     	         36	         36	              5
  users for federation query count                                        	          8	          8	              3

# saleor.graphql.accountbenchmark permission group
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  groups for federation query count                                       	          5	          5	              2
  permission group create                                                 	         21	         21	              2
  permission group delete                                                 	         22	         22	              3
  permission group query                                                  	          7	          7	              0
  permission group update                                                 	         37	         37	              1
  permission group update remove users with manage staff                  	         31	         31	              3

# saleor.graphql.appbenchmarks app extensions
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  app extensions                                                          	         15	         15	              0
  app extensions with filter[filter0]                                     	         14	         14	              0
  app extensions with filter[filter1]                                     	         10	         10	              0
  app extensions with filter[filter2]                                     	         14	         14	              0
  app extensions with filter[filter3]                                     	         10	         10	              0

# saleor.graphql.appbenchmarks apps
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  apps for federation query count                                         	          9	          9	              3

# saleor.graphql.attributebenchmark attribute
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  attribute translation                                                   	          6	          6	              0
  attribute value translation                                             	         26	         26	              0
  query attribute                                                         	          6	          6	              0
  query attributes                                                        	          8	          8	              0

# saleor.graphql.channelbenchmark channel
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  channels query                                                          	          5	          5	              0

# saleor.graphql.channelmutations channel update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  channel update mutation remove warehouse                                	         38	         38	              6

# saleor.graphql.checkoutbenchmark checkout mutations
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  add billing address to checkout                                         	         68	         68	             10
  add checkout lines                                                      	         69	         69	             11
  add checkout lines with external shipping                               	        171	        171	             68
  add checkout lines with reservations                                    	        146	        146	             54
  add delivery to checkout                                                	         68	         68	             10
  add shipping to checkout                                                	         78	         78	             15
  checkout email update                                                   	         35	         35	              1
  checkout payment charge                                                 	         47	         47	             16
  checkout shipping address update                                        	         72	         72	              9
  checkout voucher code                                                   	         86	         86	             16
  complete checkout                                                       	        180	        180	             37
  complete checkout preorder                                              	        199	        199	             48
  complete checkout with digital line                                     	        240	        240	             63
  complete checkout with out of stock webhook                             	        182	        182	             37
  complete checkout with single line                                      	        182	        182	             37
  create checkout                                                         	         80	         80	             11
  create checkout with reservations                                       	        143	        143	             30
  customer complete checkout                                              	        201	        201	             47
  customer complete checkout for cc                                       	        182	        182	             36
  update checkout lines                                                   	         62	         62	             11
  update checkout lines with reservations                                 	        153	        153	             61

# saleor.graphql.checkoutbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  user checkout details                                                   	         53	         53	              6
  user checkout details with tax app                                      	         47	         47	              3

# saleor.graphql.discountbenchmark sales
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  sales query with channel slug                                           	         19	         19	              0
  sales query withot channel slug                                         	         18	         18	              0

# saleor.graphql.discountbenchmark vouchers
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  vouchers query with channel slug                                        	         19	         19	              0
  vouchers query withot channel slug                                      	         18	         18	              0

# saleor.graphql.giftcardbenchmark gift card mutations
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  create never expiry gift card                                           	         26	         26	              4
  gift card bulk activate by staff                                        	         16	         16	              3
  update gift card                                                        	         36	         36	              4

# saleor.graphql.giftcardbenchmark gift card queries
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  filter gift cards by products                                           	         14	         14	              3
  filter gift cards by tags                                               	         12	         12	              3
  filter gift cards by used by user                                       	         13	         13	              3
  query gift card details                                                 	         14	         14	              3
  query gift cards                                                        	         12	         12	              3

# saleor.graphql.orderbenchmark fulfillment
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  fulfillment query                                                       	          9	          9	              0

# saleor.graphql.orderbenchmark fulfillment refund and return products
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  fulfillment refund products order lines                                 	         54	         54	              2
  fulfillment return products order lines                                 	         98	         98	              9

# saleor.graphql.orderbenchmark order
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  staff multiple draft orders                                             	        760	        760	            620
  staff multiple orders                                                   	        240	        240	            153
  staff order details                                                     	         60	         60	             10
  user order details                                                      	         58	         58	             11

# saleor.graphql.orderbenchmark order fulfill
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  order fulfill                                                           	         17	         17	              3
  order fulfill with gift cards                                           	         17	         17	              3

# saleor.graphql.pagebenchmark page type
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  page types for federation query count                                   	          3	          3	              0
  query page type                                                         	         18	         18	              6
  query page types                                                        	         25	         25	             12

# saleor.graphql.paymentbenchmark payment transactions
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  payment transactions                                                    	         49	         49	             20

# saleor.graphql.productbenchmark category
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  categories children                                                     	          3	          3	              0
  categories for federation query count                                   	          3	          3	              0
  category delete                                                         	         82	         82	             17
  category view                                                           	         37	         37	              2

# saleor.graphql.productbenchmark collection
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  collection add products                                                 	         36	         36	              6
  collection bulk delete                                                  	         48	         48	              8
  collection view                                                         	          6	          6	              0
  collections for federation query count                                  	          7	          7	              2
  create collection                                                       	         36	         36	              5
  delete collection                                                       	         40	         40	              7
  remove products from collection                                         	         33	         33	              6
  retrieve collection channel listings                                    	          5	          5	              0

# saleor.graphql.productbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  report product sales                                                    	         10	         10	              3
  retrieve product list                                                   	          4	          4	              0

# saleor.graphql.productbenchmark product
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  filter products by attributes                                           	          9	          9	              0
  filter products by boolean attributes                                   	         19	         19	              0
  filter products by gift card                                            	         11	         11	              1
  filter products by numeric attributes                                   	         18	         18	              0
  product create                                                          	         73	         73	              8
  product details                                                         	         45	         45	              2
  product translations                                                    	          5	          5	              0
  products for federation query count                                     	          6	          6	              2
  products media for federation query count                               	          5	          5	              0
  products types for federation query count                               	          2	          2	              0
  retrieve channel listings                                               	         21	         21	              0
  retrieve product attributes                                             	          9	          9	              0
  retrieve product images                                                 	          4	          4	              0
  retrieve product media                                                  	          4	          4	              0
  retrive products with product types and attributes                      	          7	          7	              0
  update product                                                          	         51	         51	             11

# saleor.graphql.productbenchmark product variant channel listing update
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  variant channel listing update                                          	         45	         45	              3

# saleor.graphql.productbenchmark variant
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                             	         71	         71	              3
  product variant create                                                  	         76	         76	              5
  products variants for federation query count                            	          6	          6	              2
  retrieve variant list                                                   	         39	         39	              3
  update product variant                                                  	         76	         76	              9

# saleor.graphql.productbenchmark variant stocks
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  product variants stocks create                                          	         26	         26	              4
  product variants stocks create with single webhook called               	         25	         25	              4
  product variants stocks delete by id                                    	         27	         27	              4
  product variants stocks delete by sku                                   	         27	         27	              4
  product variants stocks delete with out of stock webhook many calls     	         23	         23	              3
  product variants stocks update by sku                                   	         28	         28	              4
  product variants stocks update byid                                     	         28	         28	              4
  query product variants stocks                                           	         10	         10	              0

# saleor.graphql.producttest product sorting attributes
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                                  	         23	         23	              0

# saleor.graphql.shippingbenchmark shipping methods
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  vouchers query with channel slug                                        	          7	          7	              0
  vouchers query without channel slug                                     	          7	          7	              0

# saleor.graphql.shopbenchmark homepage
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  retrieve shop                                                           	          4	          4	              0

# saleor.graphql.warehousebenchmark stocks
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  stocks query                                                            	          5	          5	              0

# saleor.graphql.webhookbenchmark webhook events
  test name                                                               	left count 	right count	duplicate count
  ------------------------------------------------------------------------	-----------	-----------	---------------
  webhooks                                                                	          9	          9	              0

@kadewu kadewu requested a review from a team January 9, 2023 10:05
@korycins korycins mentioned this pull request Jan 11, 2023
11 tasks
@korycins korycins requested a review from a team January 11, 2023 08:48
@kadewu kadewu added the 3.9 label Jan 11, 2023
@kadewu kadewu force-pushed the move-order-settings-to-channel-3.9 branch from 9806b8c to e5ef72c Compare January 11, 2023 09:45
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (3.11@53088dc). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             3.11   #11645   +/-   ##
=======================================
  Coverage        ?   93.30%           
=======================================
  Files           ?      745           
  Lines           ?    55183           
  Branches        ?     6292           
=======================================
  Hits            ?    51490           
  Misses          ?     2412           
  Partials        ?     1281           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kadewu kadewu added the migrations perf test Runs performance tests on modified migrations label Jan 11, 2023
@saleor-deployments
Copy link

Results of migrations performance test f3e9dd8):

  • 0007_order_settings_per_channel: 0.287s
  • 0006_order_settings_fields: 0.121s

@saleor-deployments saleor-deployments bot removed the migrations perf test Runs performance tests on modified migrations label Jan 11, 2023
@kadewu kadewu force-pushed the move-order-settings-to-channel-3.9 branch 2 times, most recently from 4c7bfa2 to 28d3081 Compare January 11, 2023 14:47
@kadewu kadewu requested a review from a team as a code owner January 11, 2023 14:47
@kadewu kadewu removed the 3.9 label Jan 11, 2023
@kadewu kadewu changed the base branch from 3.9 to main January 11, 2023 14:47
@kadewu kadewu removed the request for review from a team January 11, 2023 14:47
@kadewu kadewu added test deployment Deploy test environment for pull request skip changelog labels Jan 11, 2023
@github-actions github-actions bot temporarily deployed to move-order-settings-to-channel-3-9 January 11, 2023 14:50 Inactive
@kadewu kadewu added the migrations perf test Runs performance tests on modified migrations label Jan 11, 2023
@saleor-deployments
Copy link

Results of migrations performance test 21db86c):

  • 0007_order_settings_per_channel: 0.300s
  • 0006_order_settings_fields: 0.162s

@saleor-deployments saleor-deployments bot removed the migrations perf test Runs performance tests on modified migrations label Jan 11, 2023
@kadewu kadewu force-pushed the move-order-settings-to-channel-3.9 branch from 28d3081 to 186f4cf Compare January 11, 2023 15:05
@github-actions github-actions bot temporarily deployed to move-order-settings-to-channel-3-9 January 11, 2023 15:06 Inactive
@kadewu kadewu changed the base branch from main to 3.10 January 11, 2023 15:08
@kadewu kadewu removed the test deployment Deploy test environment for pull request label Jan 11, 2023
@kadewu kadewu marked this pull request as draft February 3, 2023 09:08
@kadewu kadewu force-pushed the move-order-settings-to-channel-3.9 branch from 186f4cf to 4130ef6 Compare February 3, 2023 09:08
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023

CLA assistant check
All committers have signed the CLA.

@kadewu kadewu force-pushed the move-order-settings-to-channel-3.9 branch 2 times, most recently from 8d2151a to 29bbc1d Compare February 3, 2023 09:29
@kadewu kadewu changed the base branch from 3.10 to 3.11 February 3, 2023 09:29
@kadewu kadewu marked this pull request as ready for review February 3, 2023 09:30
@kadewu kadewu force-pushed the move-order-settings-to-channel-3.9 branch from 29bbc1d to d7453a7 Compare February 3, 2023 09:38
@kadewu kadewu mentioned this pull request Feb 3, 2023
11 tasks
@kadewu kadewu added the 3.11 label Feb 7, 2023
@kadewu kadewu force-pushed the move-order-settings-to-channel-3.9 branch from d7453a7 to 0bf37c1 Compare February 8, 2023 09:56
@kadewu kadewu merged commit d3fdb2e into 3.11 Feb 8, 2023
@kadewu kadewu deleted the move-order-settings-to-channel-3.9 branch February 8, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants