Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FAB placement #1394

Merged
merged 5 commits into from Dec 6, 2017
Merged

Change FAB placement #1394

merged 5 commits into from Dec 6, 2017

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because...

Resolves #1383

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).
  7. Python code quality checks pass: pycodestyle, pydocstyle, pylint.
  8. JavaScript code quality checks pass: eslint.

@codecov-io
Copy link

codecov-io commented Dec 1, 2017

Codecov Report

Merging #1394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1394   +/-   ##
======================================
  Coverage    83.4%   83.4%           
======================================
  Files         128     128           
  Lines        5791    5791           
  Branches      664     664           
======================================
  Hits         4830    4830           
  Misses        803     803           
  Partials      158     158

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4872d8...0df2a2a. Read the comment docs.

@dominik-zeglen dominik-zeglen changed the title Enchancement/dashboard fab Change FAB placement Dec 1, 2017
@maarcingebala
Copy link
Member

On the product list page:
image

While on the Sales list:
image

@dominik-zeglen Please make sure that all list views are consistent.

@maarcingebala maarcingebala merged commit 83d9569 into master Dec 6, 2017
@maarcingebala maarcingebala deleted the enchancement/dashboard-fab branch December 6, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants