New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the documentations with the latest requirements and restore the transifex link #2656
Update the documentations with the latest requirements and restore the transifex link #2656
Conversation
Wonder if translate should be on its own, or under Contribute section? |
README.md
Outdated
@@ -19,7 +19,7 @@ Built with top-notch technologies. Django, PostgreSQL, ElasticSearch, GraphQL an | |||
|
|||
## 💾 Installation and requirements | |||
|
|||
Saleor requires Python 3.4+, Node.js 8.0+, PostgreSQL and OS-specific dependency tools. | |||
Saleor requires Python 3.5+, Node.js 8.0+, PostgreSQL and OS-specific dependency tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably also say Node.js 10+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, Python and Node versions get listed in other places, like installation docs for linux
README.md
Outdated
## 🗺 Translate | ||
|
||
Saleor is available in 30 languages translated by our community, | ||
the repository gets synchronized weekly to the latest contributions on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also missing some invitation to contribute in the copy.
Maybe something like
Did you know that Saleor is available in almost 30 languages, translated entirely by our community?
If you'd like to help us, you can join one of our translation teams on [the localization platform Transifex](https://www.transifex.com/mirumee/saleor-1/languages/).
The repository gets synchronized weekly with the latest contributions.
README.md
Outdated
@@ -43,6 +43,12 @@ Login credentials: `admin@example.com`/`admin` | |||
* Follow us on [Twitter](https://twitter.com/getsaleor?lang=en) | |||
* Check our latest blog posts on [Medium](https://medium.com/saleor) | |||
|
|||
## 🗺 Translate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to say which emoji this is, I think that earth emoji 🌎 would be more readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
America 🌎 or Europe-Africa 🌍?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
America is better-looking, but that's the matter of preferences 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less details shown 👍
@Pacu2 we could put it under the contribute section, but it would probably be too much in a single section. We could split it up to two sub sections, but would not be looking better (by far). I think it would be better to keep it separated for the visual and to quickly catch the localization section. But maybe it would be better to move it below the |
d44d1ab
to
3d91f8e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2656 +/- ##
=======================================
Coverage 89.59% 89.59%
=======================================
Files 204 204
Lines 9898 9898
Branches 932 932
=======================================
Hits 8868 8868
Misses 746 746
Partials 284 284 Continue to review full report at Codecov.
|
Python 3.4 was dropped in #2601, this change replace the minimal Python version 3.4 to 3.5 in the documentations.
This also the restore the transifex link that was accidentally removed from the readme file.
Pull Request Checklist