Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentations with the latest requirements and restore the transifex link #2656

Merged
merged 2 commits into from Aug 23, 2018

Conversation

NyanKiyoshi
Copy link
Member

Python 3.4 was dropped in #2601, this change replace the minimal Python version 3.4 to 3.5 in the documentations.

This also the restore the transifex link that was accidentally removed from the readme file.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).

@Pacu2
Copy link
Contributor

Pacu2 commented Aug 22, 2018

Wonder if translate should be on its own, or under Contribute section?

README.md Outdated
@@ -19,7 +19,7 @@ Built with top-notch technologies. Django, PostgreSQL, ElasticSearch, GraphQL an

## 💾 Installation and requirements

Saleor requires Python 3.4+, Node.js 8.0+, PostgreSQL and OS-specific dependency tools.
Saleor requires Python 3.5+, Node.js 8.0+, PostgreSQL and OS-specific dependency tools.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably also say Node.js 10+

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Python and Node versions get listed in other places, like installation docs for linux

README.md Outdated
## 🗺 Translate

Saleor is available in 30 languages translated by our community,
the repository gets synchronized weekly to the latest contributions on
Copy link
Contributor

@Pacu2 Pacu2 Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also missing some invitation to contribute in the copy.
Maybe something like

Did you know that Saleor is available in almost 30 languages, translated entirely by our community? 
If you'd like to help us, you can join one of our translation teams on [the localization platform Transifex](https://www.transifex.com/mirumee/saleor-1/languages/).
The repository gets synchronized weekly with the latest contributions.

README.md Outdated
@@ -43,6 +43,12 @@ Login credentials: `admin@example.com`/`admin`
* Follow us on [Twitter](https://twitter.com/getsaleor?lang=en)
* Check our latest blog posts on [Medium](https://medium.com/saleor)

## 🗺 Translate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to say which emoji this is, I think that earth emoji 🌎 would be more readable

https://emojipedia.org/earth-globe-europe-africa/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

America 🌎 or Europe-Africa 🌍?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

America is better-looking, but that's the matter of preferences 😏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less details shown 👍

@NyanKiyoshi
Copy link
Member Author

@Pacu2 we could put it under the contribute section, but it would probably be too much in a single section. We could split it up to two sub sections, but would not be looking better (by far).

I think it would be better to keep it separated for the visual and to quickly catch the localization section. But maybe it would be better to move it below the Contribute section. What do you think?

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #2656 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2656   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files         204      204           
  Lines        9898     9898           
  Branches      932      932           
=======================================
  Hits         8868     8868           
  Misses        746      746           
  Partials      284      284

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c560c18...3d91f8e. Read the comment docs.

@NyanKiyoshi NyanKiyoshi changed the title Drop Python 3.4 from docs and restore the transifex link in readme Update the documentations with the latest requirements and restore the transifex link Aug 22, 2018
@maarcingebala maarcingebala merged commit d9467f9 into saleor:master Aug 23, 2018
@NyanKiyoshi NyanKiyoshi deleted the docs/update-some-information branch August 23, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants