Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2960/Turn product attributes / variant attributes into a flat list #2980

Merged
merged 7 commits into from Sep 27, 2018

Conversation

Pacu2
Copy link
Contributor

@Pacu2 Pacu2 commented Sep 27, 2018

Turned product attributes & variant attributes into a flat list

close #2960

@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@fe53197). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2980   +/-   ##
=========================================
  Coverage          ?   89.72%           
=========================================
  Files             ?      208           
  Lines             ?    10921           
  Branches          ?     1072           
=========================================
  Hits              ?     9799           
  Misses            ?      794           
  Partials          ?      328
Impacted Files Coverage Δ
saleor/graphql/product/types.py 96.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe53197...f661ca3. Read the comment docs.

@maarcingebala maarcingebala merged commit 9a168a6 into master Sep 27, 2018
@maarcingebala maarcingebala deleted the 2960/turn-attributes-into-flat-list branch September 27, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return flat attribute values list instead of connection
3 participants