New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on shipping validation #3812
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3812 +/- ##
=========================================
Coverage ? 91.61%
=========================================
Files ? 277
Lines ? 15153
Branches ? 1489
=========================================
Hits ? 13883
Misses ? 870
Partials ? 400
Continue to review full report at Codecov.
|
…sn't have a shipping address
…hipping-validation
33f65d6
to
06b1c81
Compare
@auvipy Is this an auto reply? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase.
@maarcingebala This PR is updated with master branch, please review. Thanks. |
048a558
to
f8efe64
Compare
…hipping-validation
f8efe64
to
e785e25
Compare
Closing in favor of #4367 where we're working on improved behavior of checkout API. |
is_valid_shipping_method
in API (clean_checkout
) and storefront 1.0 (clean_shipping_method
)clean_shipping_method
toclean_shipping_method
andclean_shipping_address
. They are used inCheckoutLinesAdd
/CheckoutLineUpdate
/CheckoutLineDelete
/CheckoutShippingAddressUpdate
/CheckoutShippingMethodUpdate
. I feels both address and method should be validated after cart line/shipping method/shipping address are updated.CheckoutLinesAdd
/CheckoutLineUpdate
CheckoutLinesAdd
/CheckoutLineUpdate
clean_shipping_method
is_valid_shipping_method
will raise error if cart doesn't have a shipping addressCountry
should be used instead of string for address's country field in tests.Pull Request Checklist