Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default product tax rate in Dashboard 1.0 #3880

Merged
merged 2 commits into from Mar 29, 2019

Conversation

pawelzar
Copy link
Contributor

@pawelzar pawelzar commented Mar 28, 2019

Resolves #2953

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

In product form, the product tax_rate should be selected instead of product type
tax_rate, if it's set.
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #3880 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3880   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files         263      263           
  Lines       14214    14214           
  Branches     1423     1423           
=======================================
  Hits        12889    12889           
  Misses        908      908           
  Partials      417      417
Impacted Files Coverage Δ
saleor/dashboard/product/forms.py 91.9% <100%> (ø) ⬆️
saleor/product/models.py 92.52% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb3b96...4f5e086. Read the comment docs.

@maarcingebala maarcingebala merged commit 288d98e into master Mar 29, 2019
@maarcingebala maarcingebala deleted the 2953/product-tax-rate branch March 29, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants