Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility card view #4198

Merged
merged 10 commits into from Jun 4, 2019
Merged

Fix visibility card view #4198

merged 10 commits into from Jun 4, 2019

Conversation

benekex2
Copy link
Contributor

@benekex2 benekex2 commented Jun 3, 2019

Resolves #4137

I want to merge this change because...

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #4198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4198   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         278      278           
  Lines       15548    15548           
  Branches     1513     1513           
=======================================
  Hits        14269    14269           
  Misses        879      879           
  Partials      400      400

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57510b3...c60440f. Read the comment docs.

@maarcingebala
Copy link
Member

I've spotted one wording issue - if the publication date is set in the past and you'll change the switch to "hidden" you'll get the message that is logically incorrect "Will be visible on ":

image

Maybe we'd have to check if visibility is set to "hidden" and the publication date is in the past, then we should simply say "hidden"?

@maarcingebala maarcingebala dismissed dominik-zeglen’s stale review June 4, 2019 08:49

Requested changes were made.

@maarcingebala maarcingebala merged commit 1bba8b8 into master Jun 4, 2019
@maarcingebala maarcingebala deleted the fix-visibility-card-view branch June 4, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Visibility" Card - Logic and Frontend Changes
3 participants