New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visibility card view #4198
Fix visibility card view #4198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4198 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 278 278
Lines 15548 15548
Branches 1513 1513
=======================================
Hits 14269 14269
Misses 879 879
Partials 400 400 Continue to review full report at Codecov.
|
I've spotted one wording issue - if the publication date is set in the past and you'll change the switch to "hidden" you'll get the message that is logically incorrect "Will be visible on ": Maybe we'd have to check if visibility is set to "hidden" and the publication date is in the past, then we should simply say "hidden"? |
saleor/static/dashboard-next/pages/components/PageDetailsPage/PageDetailsPage.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/VisibilityCard/VisibilityCard.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/VisibilityCard/VisibilityCard.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/VisibilityCard/VisibilityCard.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/VisibilityCard/VisibilityCard.tsx
Outdated
Show resolved
Hide resolved
saleor/static/dashboard-next/components/VisibilityCard/VisibilityCard.tsx
Outdated
Show resolved
Hide resolved
...tatic/dashboard-next/products/components/ProductAvailabilityForm/ProductAvailabilityForm.tsx
Outdated
Show resolved
Hide resolved
Requested changes were made.
Resolves #4137
I want to merge this change because...
Screenshots
Pull Request Checklist