New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default decimal places #6098
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6098 +/- ##
==========================================
+ Coverage 91.78% 91.80% +0.02%
==========================================
Files 389 389
Lines 25554 25621 +67
Branches 2410 2407 -3
==========================================
+ Hits 23454 23521 +67
- Misses 1515 1516 +1
+ Partials 585 584 -1
Continue to review full report at Codecov.
|
3cc2a23
to
caef3b0
Compare
Here is the report for 6b5bf47 (mirumee/saleor @ update-default-decimal-places) **Found 1 differences!** (click me)
# saleor.graphql.accountbenchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
delete staff members 32 32 0
query staff user 20 20 4
staff create 22 22 4
staff update groups and permissions 33 33 5
# saleor.graphql.accountbenchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 19 19 2
permission group delete 20 20 3
permission group query 7 7 0
permission group update 33 33 1
permission group update remove users with manage staff 27 27 3
# saleor.graphql.checkoutbenchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 72 72 42
add shipping to checkout 50 50 19
checkout email update 41 41 21
checkout payment charge 38 38 10
checkout shipping address update 58 58 19
checkout voucher code 85 85 53
- complete checkout 118 119 25
create checkout 130 130 64
update checkout lines 114 114 54
# saleor.graphql.checkoutbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user checkout details 51 51 27
# saleor.graphql.menubenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve secondary menu 5 5 0
# saleor.graphql.orderbenchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user order details 17 17 3
# saleor.graphql.productbenchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
category view 18 18 1
# saleor.graphql.productbenchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
collection view 17 17 0
# saleor.graphql.productbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
featured products list 14 14 0
retrieve product list 5 5 0
# saleor.graphql.productbenchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product details 16 16 0
retrieve product attributes 7 7 0
# saleor.graphql.productbenchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variant bulk create 47 47 2
retrieve variant list 18 18 2
# saleor.graphql.productbenchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 22 22 5
product variants stocks delete 19 19 5
product variants stocks update 27 27 5
# saleor.graphql.producttest product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 20 20 0
# saleor.graphql.shopbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve shop 2 2 0 |
…leor into update-default-decimal-places
f558010
to
9640fb8
Compare
60c92fc
to
b081945
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
03217fe
to
6b5bf47
Compare
Changing currency caused errors when running Saleor.
DEFAULT_DECIMAL_PLACES
to 3, which should be enough for all currencies (https://en.wikipedia.org/wiki/ISO_4217).decimal_places
inDecimalFields
Money
ObjectType - return amount with the number of decimal places corresponding to a given currencyPositiveDecimal
that contains validation - prevent for creating an item with a negative valueRequire frontend changes
Resolves #5360
Impact
Pull Request Checklist