Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Multipart Uploads Don't Work #80

Closed
Miserlou opened this issue May 11, 2016 · 9 comments
Closed

Binary Multipart Uploads Don't Work #80

Miserlou opened this issue May 11, 2016 · 9 comments

Comments

@Miserlou
Copy link
Owner

Investigating, I thought we no longer required B64 encoding, but it seems way may, or there is another problem at work.

@Miserlou
Copy link
Owner Author

File uploads appear to be ballooning up in size across the APIGW:

176372: local app
314044: Zappa app

Investigating..

@Miserlou
Copy link
Owner Author

I don't know. I suspect it has something to do with byte encodings, but it looks like the file is too big by the time it even makes it through the APIGW, before we even touch it.

@Miserlou
Copy link
Owner Author

Bugger. This is an API Gateway problem - B64 encoding image uploads is still necessary for the time being: https://forums.aws.amazon.com/thread.jspa?threadID=231371&tstart=0

@Miserlou Miserlou changed the title Multipart Image Uploads Seem to Be Broken Binary Multipart Uploads Don't Work May 12, 2016
@anush0247
Copy link

anush0247 commented Aug 26, 2016

@Miserlou we have implemented django admin file widget to upload files in django zappa admin panels. I hope this can help. check out: https://github.com/anush0247/zappa-file-widget

@Miserlou
Copy link
Owner Author

Woah, that's awesome!

@Miserlou
Copy link
Owner Author

Related: #481

@Miserlou
Copy link
Owner Author

Binary downloads work, could be interesting to revisit binary uploads now.

@Miserlou
Copy link
Owner Author

Miserlou commented Mar 6, 2017

Binary uploads work now.

@Miserlou Miserlou closed this as completed Mar 6, 2017
@JamesQAQ
Copy link

JamesQAQ commented Mar 7, 2017

I have deployed my django project to s3 bucket about 3 weeks ago, and find out there was an issue about binary file uploads.
After seeing this issue closed, I updated zappa and tried to update but get the warning below:

Warning! Couldn't get function treasure-django-dev in us-east-1 - have you deployed yet?

My command:
zappa update dev

My zappa_settings.json:

{
    "dev": {
        "django_settings": "treasure.settings",
        "s3_bucket": "free-gifts-zappa"
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants