Upgrade Guice to 5.0.1 and Kotlin to 1.4.32 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnlcox Would this update be something you're interested in for the repo? |
|
Thanks. This look great. Are there any other changes in Guice 5.x that might be incompatible with 4.x? I'm wondering if this should bump kotlin-guice to a 2.x release. |
|
Reading through the release notes I don't see anything breaking. There's the change from cglib to a custom built library instead but there shouldn't be any need to do any sort of migration for a user from my understanding of reading the notes |
|
@johnlcox Let me know if there's anything else I should do here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades:
Guice 5.0.1 replaces cglib which removes a ton of 'illegal reflective access' warnings that previously came from Guice when running it on newer versions of JVM.