Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment step count with frame-skip #3

Closed
rlbeaverton opened this issue Apr 28, 2020 · 3 comments
Closed

Environment step count with frame-skip #3

rlbeaverton opened this issue Apr 28, 2020 · 3 comments

Comments

@rlbeaverton
Copy link

Great work and thanks a lot for releasing the code! It’s awesome to see this simple contrastive loss term performing so well without the need for reconstruction.

Quick question regarding the environment step count: if we consider a DMC episode of standard length 1000 steps and we use a frameskip of 4, do the reported results consider the episode to have 1000 steps or 250 steps? Put differently, do the 100k step results mean 100k “low-level DMC” steps or 100k “agent-applying-an-action” steps?

@MishaLaskin
Copy link
Owner

MishaLaskin commented Apr 29, 2020

reported results are low-level DMC environment steps (1k per episode)

@rlbeaverton
Copy link
Author

Quick follow-up after reading "Image Augmentation Is All You Need: Regularizing Deep Reinforcement Learning from Pixels" by Kostrikov et al., in which they state:

In contrast to prior work, CURL [42] plots returns as a function of modified environment steps, i.e. true environment steps divided by the action-repeat hyper-parameter.

Is their assertion then wrong? Thanks!

@MishaLaskin
Copy link
Owner

we count environment steps (100k env steps = 25k agent steps with action repeat of 4), please refer to section 5.1 https://arxiv.org/pdf/2004.04136.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants