Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing support #8

Open
maks opened this issue Dec 2, 2021 · 3 comments
Open

testing support #8

maks opened this issue Dec 2, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@maks
Copy link
Contributor

maks commented Dec 2, 2021

Thank you for such a nice package. I noticed there are no unit tests yet, I'd like to add some, but I think the main blocker to do so at the moment is that it's not possible to pass in DioWrapper as a constructor param to Auth0Client.

I realise that most of the methods don't really have any business logic in them to test, but I think it would be useful in a few places, like passwordGrant() to test that grant_type is set correctly.

Would you be open to changing the Auth0Client API to allow that?
@mishatron
Copy link
Owner

@maks Make a pull request with changes you want and I`ll check it. Thanks for contributing

@mishatron mishatron added the enhancement New feature or request label Dec 4, 2021
@mishatron
Copy link
Owner

@maks Would you like to provide some tests?

@maks
Copy link
Contributor Author

maks commented Feb 1, 2022

Yes sorry about the delay, I haven't had a chance to get back to working on the refactor to add tests. I'll try to get a PR ready shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maks @mishatron