make collapse_vars consistent with toplevel
#1608
Conversation
lib/compress.js
Outdated
| @@ -558,7 +559,8 @@ merge(Compressor.prototype, { | |||
|
|
|||
| // Only interested in cases with just one reference to the variable. | |||
| var def = self.find_variable && self.find_variable(var_name); | |||
| if (!def || !def.references || def.references.length !== 1 || var_name == "arguments") { | |||
| if (!def || !def.references || def.references.length !== 1 | |||
| || var_name == "arguments" || !toplevel && def.global) { | |||
There was a problem hiding this comment.
I know this code is correct, but could you please put unnecessary parens around (!toplevel && def.global) ?
There was a problem hiding this comment.
Ah, I was wondering who put all those parentheses throughout the codebase 👻
No problem, consider it done 😉
There was a problem hiding this comment.
I just find it easier to read.
I know, I know... Uglify devs should not need any whitespace and unnecessary parens. ;-)
test/compress/collapse_vars.js
Outdated
| } | ||
| input: { | ||
| function foo() { | ||
| return 1; |
There was a problem hiding this comment.
Could you please define function foo as the following to show that collapse_vars works in functions regardless of the toplevel setting?
function foo(x){ var y = x; return y; }
test/compress/collapse_vars.js
Outdated
| input: { | ||
| function foo() { | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
Could you please define function foo as the following to show that collapse_vars works in functions regardless of the toplevel setting?
function foo(x){ var y = x; return y; }
|
Thanks! LGTM. |
fixes #1605
/cc @kzc