Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle runtime errors in expect_stdout #1618

Merged
merged 1 commit into from Mar 17, 2017

Conversation

alexlamsl
Copy link
Collaborator

allow test to pass if both input and expect throws the same kind of error

allow test to pass if both `input` and `expect` throws the same kind of error
@alexlamsl
Copy link
Collaborator Author

https://github.com/mishoo/UglifyJS2/pull/1618/files?w=1 might make it marginally easier to review

@kzc
Copy link
Contributor

kzc commented Mar 17, 2017

At least it'll be consistent. Consider:

$ echo 'const a = 1; console.log(a++);' | node0_10_41 
1
$ echo 'const a = 1; console.log(a++);' | node421
1
$ echo 'const a = 1; console.log(a++);' | node690
[stdin]:1
const a = 1; console.log(a++);
                          ^

TypeError: Assignment to constant variable.

@alexlamsl alexlamsl merged commit 0489d6d into mishoo:master Mar 17, 2017
@alexlamsl alexlamsl deleted the expect-error branch March 17, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants