fix collapse_vars regression in destructuring
#2897
Conversation
| @@ -208,7 +208,7 @@ function run_compress_tests() { | |||
| }); | |||
| return false; | |||
| } | |||
| if (0 && test.reminify && !reminify(test.options, input_code, input_formatted, test.expect_stdout)) { | |||
| if (test.reminify && !reminify(test.options, input_code, input_formatted, test.expect_stdout)) { | |||
There was a problem hiding this comment.
Please leave this out - I don't want to redo this for every harmony merge.
There was a problem hiding this comment.
Why release uglify-es at all then if every new uglify-js feature renders it unusable?
There was a problem hiding this comment.
I'm performing this merge on a best-effort basis, in the belief that it would be usable for the majority of use cases out there.
If this is not the case and requires more effort on my part, I would indeed stop making any future uglify-es releases.
There was a problem hiding this comment.
Thanks for your work on uglify-es. I appreciate you'd rather concentrate on uglify-js.
A reminify test failure is no different than a regular test failure. Disabling it would just mask future regressions. It would be best not to release uglify-es with known regressions and just let harmony diverge from master.
There was a problem hiding this comment.
Okay - in that case this is the last PR I would accept for harmony and it shall be frozen from now on.
There was a problem hiding this comment.
@alexlamsl any chance we get a quick bugfix release for uglify-es though? This regression hit many of our projects using uglifyjs-webpack-plugin.
|
Do you guys have any ETA for landing the npm version with this fix? |
|
@diervo I believe this already landed in v3.3.11... and v3.3.12 is out as well with all changes of current master. |
|
@AviVahl But thats not for the harmony version isn't it? Or am I confused? |
|
He wrote:
So I'm really not sure anymore, heh.
|
|
This PR fixes a regression in |
|
Since 3.3.10 was deprecated various @alexlamsl To reduce confusion please consider adding a note to the top of the harmony README saying that |
|
@kzc I don't think anyone would be able to see the note, as https://www.npmjs.com/package/uglify-es only shows a copy of |
|
@alexlamsl So publish 3.3.11 with that just that README addition to the harmony branch. |
|
Too much error-prone work for zero gain on my part - |
|
No need to merge master into harmony. Just a README addition. |
|
I understand what you are trying to say - it means I need to checkout I'm just not comfortable with that. |
|
No need to do any of that - use latest harmony as is. Add one line to the README saying |
|
Doing so you are assuming there are no other bugs within |
|
No code is bug free. It's all relative - latest harmony has fewer ES6 bugs than Then put a note in the issue template saying |
|
That is a rational viewpoint, and if I've been getting rational responses that would be the best course of action - hell, I might even be interested in keeping For the time being, I just don't want anything to do with it, after receiving such goodwill as, and not limited to, creating dedicated repository just to hurl personal insults in hit-and-run style. I know I am being difficult, and I do apologise for that. |
fixes #2896