use /dev/tty instead of /dev/stdout when prompting for information

[nhooyr]

See neovim/neovim#5211

[mislav]

Thanks, that is good advice! I'll have to look into how to implement this change in Go. To clear things up, which prompts from hub are you talking about?

[nhooyr]

At the very start, when it asks for the username/password for the token. https://github.com/github/hub/blob/af72087bc7c4f94cf5876b22820fa9e4cf772700/github/config.go#L137-L138

[nhooyr]

It's a very simple change. Open /dev/tty when prompting, but if you cannot, exit with an error.

[nhooyr]

I'll just go ahead and create the PR.

[mislav]

Here's where we use stdin in this context. Go doesn't expose anything like os.Tty, but I guess we could just manually open /dev/tty. On Windows, I presume this won't be available, so we will continue using /dev/stdin there.

There is also interesting mentions of "tty" here https://golang.org/pkg/syscall/#SysProcAttr

Should we also write out the prompt to /dev/tty as well, or just read from it?

[nhooyr]

Yes, we have to write it out to /dev/tty as well.

[nhooyr]

Sorry never mind, I've got to do something else. Will not be able to work on the PR.

[mislav]

No problem. Thanks for suggesting this in the first place.

[nhooyr]

Going to close as it has been a long time and I'm not sure if this is relevant anymore.